Allows files and directories to inputs and handles them based on type #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsherGlick
requested changes
Oct 18, 2023
AsherGlick
requested changes
Nov 5, 2023
AsherGlick
reviewed
Nov 5, 2023
xml_converter/src/xml_converter.cpp
Outdated
| xml_filepath = output_path + "xml_file.xml"; | ||
| } | ||
| else { | ||
| xml_filepath = output_path; |
There was a problem hiding this comment.
I dont understand why this does not have xml_file.xml
AsherGlick
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code had an issue where if a xml file was given as an input, the program would segfault. These changes allow an xml file to be passed in as well as allow the user to specify the name of the output file.